Re: [Qemu-devel] [PATCH v1 1/1] xlnx-ep108: Fix minimum RAM check

[Peter Maydell]

On 20 November 2015 at 12:09, Alistair Francis
<address@hidden> wrote:
> The minimum RAM check logic for the Xiilnx EP108 was off by one,
> which caused a false positive. Correct the logic to only print
> warnings when the RAM is below 0x8000000.
>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
>
>  hw/arm/xlnx-ep108.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c
> index 2899698..85b978f 100644
> --- a/hw/arm/xlnx-ep108.c
> +++ b/hw/arm/xlnx-ep108.c
> @@ -51,7 +51,7 @@ static void xlnx_ep108_init(MachineState *machine)
>          machine->ram_size = EP108_MAX_RAM_SIZE;
>      }
>
> -    if (machine->ram_size <= 0x08000000) {
> +    if (machine->ram_size < 0x08000000) {
>          qemu_log("WARNING: RAM size " RAM_ADDR_FMT " is small for EP108",
>                   machine->ram_size);
>      }
> --
> 2.5.0

Applied, thanks.

-- PMM