Re: [Qemu-devel] [PATCH REPOST 1/2] dump-guest-memory: add "detach" flag for QMP/HMP interfaces

[Fam Zheng]

On Mon, 11/23 09:10, Eric Blake wrote:
> On 11/23/2015 03:07 AM, Peter Xu wrote:
> > This patch only add the interfaces, but not implementing them.
> > 
> > Signed-off-by: Peter Xu <address@hidden>
> > ---
> >  dump.c           | 3 ++-
> >  hmp-commands.hx  | 5 +++--
> >  hmp.c            | 3 ++-
> >  qapi-schema.json | 3 ++-
> >  qmp-commands.hx  | 4 ++--
> >  5 files changed, 11 insertions(+), 7 deletions(-)
> > 
> 
> > +++ b/qapi-schema.json
> > @@ -2132,7 +2132,8 @@
> >  ##
> >  { 'command': 'dump-guest-memory',
> >    'data': { 'paging': 'bool', 'protocol': 'str', '*begin': 'int',
> > -            '*length': 'int', '*format': 'DumpGuestMemoryFormat' } }
> > +            '*length': 'int', '*format': 'DumpGuestMemoryFormat',
> > +            'detach': 'bool'} }
> 
> Missing documentation of the new flag, of its default state, and with a
> mention that it is '(since 2.6)'.
> 

Yes, also new flags must be added as optional to keep backward-compatibility.

Fam