[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.5] block-migration: limit the memory usage
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH for-2.5] block-migration: limit the memory usage |
Date: |
Tue, 24 Nov 2015 12:47:24 +0800 |
User-agent: |
Mutt/1.5.23 (2015-06-09) |
On Mon, Nov 23, 2015 at 05:31:33PM +0100, Juan Quintela wrote:
> Wen Congyang <address@hidden> wrote:
> > If we set migration speed in a very large value, block-migration will try
> > to read
> > all data to the memory. Because
> > (block_mig_state.submitted + block_mig_state.read_done) * BLOCK_SIZE
> > will be overflow, and it will be always less than rate limit.
> >
> > There is no need to read too many data into memory when the rate limit is
> > very large.
> > So limit the memory usage can fix the overflow problem.
> >
> > Signed-off-by: Wen Congyang <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
>
> If no block layer maintainer objects, I will apply this to my tree.
>
> Later, Juan.
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature