[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output paramete
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output parameter to block status query functions |
|
Date: |
Tue, 24 Nov 2015 12:47:27 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 24/11/2015 06:21, Fam Zheng wrote:
> + if (bs->file && *file == bs->file->bs &&
This check is unnecessary, just use "if (file)".
Paolo
> (ret & BDRV_BLOCK_DATA) && !(ret & BDRV_BLOCK_ZERO) &&
> (ret & BDRV_BLOCK_OFFSET_VALID)) {
> + BlockDriverState *file2;
> int file_pnum;
>
> - ret2 = bdrv_co_get_block_status(bs->file->bs, ret >>
> BDRV_SECTOR_BITS,
> - *pnum, &file_pnum);
> + ret2 = bdrv_co_get_block_status(*file, ret >> BDRV_SECTOR_BITS,
> + *pnum, &file_pnum, &file2);
[Qemu-devel] [PATCH for-2.6 03/14] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status, Fam Zheng, 2015/11/24
[Qemu-devel] [PATCH for-2.6 04/14] raw: Assign bs to file in raw_co_get_block_status, Fam Zheng, 2015/11/24
[Qemu-devel] [PATCH for-2.6 05/14] iscsi: Assign bs to file in iscsi_co_get_block_status, Fam Zheng, 2015/11/24
[Qemu-devel] [PATCH for-2.6 06/14] parallels: Assign bs->file->bs to file in parallels_co_get_block_status, Fam Zheng, 2015/11/24