[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/10] trace: [tcg] Identify events with the
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/10] trace: [tcg] Identify events with the 'vcpu' property |
Date: |
Tue, 24 Nov 2015 10:54:49 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/24/2015 10:09 AM, Lluís Vilanova wrote:
> A separate ID space ('TRACE_CPU_*') is used in attribute 'cpu_id' that
> only contains events with the 'vcpu' property.
>
> These are later used to select the appropriate physical TB cache based
> on what events are active.
>
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> +++ b/qapi/trace.json
> @@ -1,6 +1,6 @@
> # -*- mode: python -*-
> #
> -# Copyright (C) 2011-2014 Lluís Vilanova <address@hidden>
> +# Copyright (C) 2011-2015 Lluís Vilanova <address@hidden>
> #
> # This work is licensed under the terms of the GNU GPL, version 2 or later.
> # See the COPYING file in the top-level directory.
> @@ -29,11 +29,12 @@
> #
> # @name: Event name.
> # @state: Tracing state.
> +# @vcpu: Whether this is a per-vCPU event (since 2.5).
You've missed 2.5 hard freeze; this will need to be 2.6.
Also, I note that patch 9/10 touches the same line again to make it
optional; why not just have it be optional in the beginning, to reduce
churn within the series?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/10] trace: Per-vCPU tracing states, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 02/10] trace: Add 'vcpu' event property, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 03/10] trace: [tcg] Identify events with the 'vcpu' property, Lluís Vilanova, 2015/11/24
- Re: [Qemu-devel] [PATCH v2 03/10] trace: [tcg] Identify events with the 'vcpu' property,
Eric Blake <=
- [Qemu-devel] [PATCH v2 05/10] exec: [ŧcg] Use multiple physical TB caches, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 04/10] exec: [tcg] Refactor flush of per-CPU virtual TB cache, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 08/10] disas: Remove unused macro '_', Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 07/10] [trivial] Track when QEMU has finished initialization, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 09/10] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 01/10] trace: Add support for vCPU pointers in trace events, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 10/10] trace: [tcg] Generate TCG code to trace guest events on a per-vCPU basis, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 06/10] exec: [tcg] Track which vCPU is performing translation and execution, Lluís Vilanova, 2015/11/24