Re: [Qemu-devel] [PATCH v2 09/10] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property

[Lluís Vilanova]

Eric Blake writes:

> On 11/24/2015 10:09 AM, Lluís Vilanova wrote:
>> Each event with the 'vcpu' property gets a per-vCPU dynamic tracing state.
>> 
>> The set of enabled events with the 'vcpu' and 'tcg' properties is used
>> to select a per-vCPU physical TB cache.  The number of events with both
>> properties is used to select the number of physical TB caches, and a
>> bitmap of the identifiers of such enabled events is used to select a
>> physical TB cache.
>> 
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> ---

>> +++ b/qapi/trace.json
>> @@ -29,7 +29,7 @@
>> #
>> # @name: Event name.
>> # @state: Tracing state.
>> -# @vcpu: Whether this is a per-vCPU event (since 2.5).
>> +# @vcpu: #optional Whether this is a per-vCPU event (since 2.5).
>> #
>> # Since 2.2
>> ##

> Spurious hunk? It looks like vcpu is always present on output, and that
> it is only...

>> @@ -42,13 +42,18 @@
>> # Query the state of events.
>> #
>> # @name: Event name pattern (case-sensitive glob).
>> +# @vcpu: #optional The vCPU to check (any by default; since 2.5).

> ...the new input place where it is optional.

Whoops! Misplaced tag, thanks.

> 2.6.

Done.


Thanks,
  Lluis

-- 
"And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer."
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth