[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-2.5 4/5] ivshmem: Mark questionable socket type t
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL for-2.5 4/5] ivshmem: Mark questionable socket type test FIXME |
Date: |
Wed, 25 Nov 2015 11:40:28 +0100 |
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
hw/misc/ivshmem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 83d7bd3..edb2270 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -939,6 +939,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error
**errp)
memory_region_add_subregion(&s->bar, 0, mr);
pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
} else if (s->server_chr != NULL) {
+ /* FIXME do not rely on what chr drivers put into filename */
if (strncmp(s->server_chr->filename, "unix:", 5)) {
error_setg(errp, "chardev is not a unix client socket");
return;
--
2.4.3
- [Qemu-devel] [PULL for-2.5 0/5] ivshmem patches for 2.5, Markus Armbruster, 2015/11/25
- [Qemu-devel] [PULL for-2.5 3/5] tests/ivshmem-test: Supply missing initializer in get_device(), Markus Armbruster, 2015/11/25
- [Qemu-devel] [PULL for-2.5 4/5] ivshmem: Mark questionable socket type test FIXME,
Markus Armbruster <=
- [Qemu-devel] [PULL for-2.5 1/5] qemu-doc: Fix ivshmem example markup, Markus Armbruster, 2015/11/25
- [Qemu-devel] [PULL for-2.5 2/5] qemu-doc: Fix ivshmem usage example with shm=..., Markus Armbruster, 2015/11/25
- [Qemu-devel] [PULL for-2.5 5/5] ivshmem: Rename property memdev to x-memdev for 2.5, Markus Armbruster, 2015/11/25
- Re: [Qemu-devel] [PULL for-2.5 0/5] ivshmem patches for 2.5, Peter Maydell, 2015/11/25