qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 for-2.5 08/12] qjson: replace QString in JSON


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 for-2.5 08/12] qjson: replace QString in JSONLexer with GString
Date: Wed, 25 Nov 2015 15:16:30 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 11/25/2015 02:23 PM, Markus Armbruster wrote:
> From: Paolo Bonzini <address@hidden>
> 
> JSONLexer only needs a simple resizable buffer.  json-streamer.c
> can allocate memory for each token instead of relying on reference
> counting of QStrings.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> Message-Id: <address@hidden>
> [Straightforwardly rebased on my patches, checkpatch made happy]
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  include/qapi/qmp/json-lexer.h    |  8 ++++----
>  include/qapi/qmp/json-streamer.h |  1 +
>  qobject/json-lexer.c             | 22 ++++++++--------------
>  qobject/json-streamer.c          |  9 +++++----
>  4 files changed, 18 insertions(+), 22 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]