[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/9] exec: remove warning about mempath and hugetlbfs
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 4/9] exec: remove warning about mempath and hugetlbfs |
Date: |
Thu, 26 Nov 2015 16:52:12 +0100 |
From: "Daniel P. Berrange" <address@hidden>
The gethugepagesize() method in exec.c printed a warning if
the file path for "-mem-path" or "-object memory-backend-file"
was not on a hugetlbfs filesystem. This warning is bogus, because
QEMU functions perfectly well with the path on a regular tmpfs
filesystem. Use of hugetlbfs vs tmpfs is a choice for the management
application or end user to make as best fits their needs. As such it
is inappropriate for QEMU to have an opinion on whether the user's
choice is right or wrong in this case.
Signed-off-by: Daniel P. Berrange <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
exec.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/exec.c b/exec.c
index b09f18b..de1cf19 100644
--- a/exec.c
+++ b/exec.c
@@ -1196,9 +1196,6 @@ static long gethugepagesize(const char *path, Error
**errp)
return 0;
}
- if (fs.f_type != HUGETLBFS_MAGIC)
- fprintf(stderr, "Warning: path not on HugeTLBFS: %s\n", path);
-
return fs.f_bsize;
}
--
2.5.0
- [Qemu-devel] [PULL v2 0/9] Misc patches for QEMU 2.5-rc2, Paolo Bonzini, 2015/11/26
- [Qemu-devel] [PULL 2/9] call bdrv_drain_all() even if the vm is stopped, Paolo Bonzini, 2015/11/26
- [Qemu-devel] [PULL 1/9] MAINTAINERS: Update TCG CPU cores section, Paolo Bonzini, 2015/11/26
- [Qemu-devel] [PULL 4/9] exec: remove warning about mempath and hugetlbfs,
Paolo Bonzini <=
- [Qemu-devel] [PULL 5/9] target-sparc: fix 32-bit truncation in fpackfix, Paolo Bonzini, 2015/11/26
- [Qemu-devel] [PULL 3/9] Revert "exec: silence hugetlbfs warning under qtest", Paolo Bonzini, 2015/11/26
- [Qemu-devel] [PULL 6/9] virtio-scsi: don't crash without a valid device, Paolo Bonzini, 2015/11/26
- [Qemu-devel] [PULL 7/9] target-i386: kvm: Abort if MCE bank count is not supported by host, Paolo Bonzini, 2015/11/26
- [Qemu-devel] [PULL 9/9] target-i386: kvm: Print warning when clearing mcg_cap bits, Paolo Bonzini, 2015/11/26
- [Qemu-devel] [PULL 8/9] target-i386: kvm: Use env->mcg_cap when setting up MCE, Paolo Bonzini, 2015/11/26
- Re: [Qemu-devel] [PULL v2 0/9] Misc patches for QEMU 2.5-rc2, Peter Maydell, 2015/11/26