[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_CO
|
From: |
Peter Xu |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED |
|
Date: |
Fri, 27 Nov 2015 19:29:29 +0800 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Nov 27, 2015 at 11:15:35AM +0100, Paolo Bonzini wrote:
>
>
> On 27/11/2015 03:48, Peter Xu wrote:
> > +##
> > +# @DUMP_COMPLETED
> > +#
> > +# Emitted when background dump has completed
> > +#
> > +# Since: 2.6
> > +##
> > +{ 'event': 'DUMP_COMPLETED' ,
> > + 'data': { 'msg': 'str' } }
>
> This makes it hard to understand whether there was an error or not. I
> suggest using '*error': 'str' instead, and omitting the error if the
> dump is successful.
Will adopt it. Thanks!
Peter
>
> Paolo
- Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support., (continued)
Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support., Paolo Bonzini, 2015/11/27
[Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/11/26
[Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status, Peter Xu, 2015/11/26
Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status, Eric Blake, 2015/11/30
[Qemu-devel] [PATCH v2 6/8] dump-query: implement "status" of "dump-query" command., Peter Xu, 2015/11/26