Re: [Qemu-devel] [PATCH COLO-Frame v11 35/39] filter-buffer: Accept zero interval

[Yang Hongyang]

On 2015年11月24日 17:25, zhanghailiang wrote:
> For default buffer filter, its 'interval' value is zero,
> so here we should accept zero interval.
>
> Signed-off-by: zhanghailiang <address@hidden>
> Cc: Jason Wang <address@hidden>
> Cc: Yang Hongyang <address@hidden>

Reviewed-by: Yang Hongyang <address@hidden>

> ---
> v11:
> - Add comment
> v10:
> - new patch
> ---
>   net/filter-buffer.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/net/filter-buffer.c b/net/filter-buffer.c
> index 195af68..5cab4fc 100644
> --- a/net/filter-buffer.c
> +++ b/net/filter-buffer.c
> @@ -116,16 +116,6 @@ static void filter_buffer_setup(NetFilterState *nf, Error 
> **errp)
>       FilterBufferState *s = FILTER_BUFFER(nf);
>       char *path = object_get_canonical_path_component(OBJECT(nf));
>
> -    /*
> -     * We may want to accept zero interval when VM FT solutions like MC
> -     * or COLO use this filter to release packets on demand.
> -     */
> -    if (!s->interval) {
> -        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval",
> -                   "a non-zero interval");
> -        return;
> -    }
> -
>       s->incoming_queue = qemu_new_net_queue(qemu_netfilter_pass_to_next, nf);
>       s->is_default = !strcmp(path, "nop");
>       if (s->interval) {

--
Thanks,
Yang