[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb
|
From: |
Alex Bennée |
|
Subject: |
Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb |
|
Date: |
Fri, 27 Nov 2015 11:57:59 +0000 |
|
User-agent: |
mu4e 0.9.15; emacs 24.5.50.4 |
Tim Sander <address@hidden> writes:
> Hi Alex
>
> Thanks for your feedback, answers as usual inline.
>
> Am Donnerstag, 26. November 2015, 18:07:35 schrieb Alex Bennée:
>> Tim Sander <address@hidden> writes:
>> > Hi
>> >
<snip>
>> You are missing a s-o-b line and scripts/checkpatch.pl complains about a
>> few things you should fix before your next submission.
> I was unsure about the access length so i was just asking for feedback this
> time, thats why omitted the signed of by line.
> It seems as if i grabbed an older version of checkpatch as these errors didn't
> come up with the slightly older script. These new occurences will be fixed.
Cool. FWIW I always run against the current
$(QEMU_SRC)/scripts/checkpatch.pl as it is updated reasonably
frequently.
--
Alex Bennée