Re: [Qemu-devel] [PATCH for-2.5] virtio-9p: use QEMU thread pool

[Greg Kurz]

On Fri, 27 Nov 2015 14:08:47 +0100
Paolo Bonzini <address@hidden> wrote:

> 
> 
> On 27/11/2015 13:42, Greg Kurz wrote:
> > On Fri, 27 Nov 2015 12:43:06 +0100
> > Paolo Bonzini <address@hidden> wrote:
> > 
> >> The QEMU thread pool already has a mechanism to invoke callbacks in the 
> >> main
> >> thread.  It does not need an EventNotifier and it is more efficient too.
> >> Use it instead of GAsyncQueue + GThreadPool + glue.
> >>
> >> As a side effect, it silences Coverity's complaint about an unchecked
> >> return value for event_notifier_init.
> > 
> > And it makes the code a lot nicer too !
> 
> Thanks. :)
> 
> >> Signed-off-by: Paolo Bonzini <address@hidden>
> >> ---
> > 
> > I have just one minor remark in hw/9pfs/virtio-9p-coth.h but anyway:
> > 
> > Reviewed-by: Greg Kurz <address@hidden>
> > Tested-by: Greg Kurz <address@hidden>
> 
> Would you like to send a pull request for these patches yourself, and
> possibly add yourself to MAINTAINERS?  I can help you setting up git
> (next week).
> 
> Paolo
> 

I'd be glad to. I'll ping you next week then :)

Cheers.

--
Greg