[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 07/15] q35: Check propery to determine if iommu i
From: |
Bandan Das |
Subject: |
Re: [Qemu-devel] [PULL 07/15] q35: Check propery to determine if iommu is set |
Date: |
Sun, 29 Nov 2015 13:22:26 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hi Marcel,
Marcel Apfelbaum <address@hidden> writes:
...
>
> Maybe is too late, but this contradicts QEMU usage, as I understand
Why late ? We can always revert it :)
> object_property_get_* should be used when we don't know object's type.
My understanding is that it's not mandatory to use it only when type
is unknown. Ofcourse, it makes it redundant when you do know the type.
I tend to follow convention, I noticed another call to qdev_get_machine,
and so opted for this. I am actually ok either way and don't prefer one way
over the other.
> Why use "iommu" when you can simply call current_machine->iommu ?
> (if you don't like the wrapper, which is pretty harmless in my opinion)
>
> Thanks,
> Marcel
>
>> mch_init_dmar(mch);
>> }
>> }
>>
- [Qemu-devel] [PULL 00/15] vhost, pc: fixes for 2.5, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 01/15] vhost: let SET_VRING_ENABLE message depends on protocol feature, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 02/15] vhost: don't send RESET_OWNER at stop, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 03/15] vhost-user: update spec description, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 04/15] vhost-user-test: support VHOST_USER_SET_VRING_ENABLE, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 06/15] vhost-user: start/stop all rings, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 07/15] q35: Check propery to determine if iommu is set, Michael S. Tsirkin, 2015/11/19
- [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu, Michael S. Tsirkin, 2015/11/19