[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" su
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support. |
Date: |
Mon, 30 Nov 2015 09:48:38 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, 11/28 13:51, Peter Xu wrote:
> On Fri, Nov 27, 2015 at 01:14:25PM +0800, Fam Zheng wrote:
> > On Fri, 11/27 10:48, Peter Xu wrote:
>
> [snip]
>
> >
> > This patch doesn't handle the incoming migration case, i.e. when QEMU is
> > started with "-incoming", or "-incoming defer". Dump can go wrong when
> > incoming
> > migration happens at the same time.
>
> Sorry to missed these lines. Still not understand why this patch
> cannot handle this if with [1] (Please check below for [1])?
You're right, that does work. I missed that "defer" also sets
RUN_STATE_INMIGRATE.
Fam
- Re: [Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces., (continued)
Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support., Paolo Bonzini, 2015/11/27
[Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/11/26