[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] question: about exec/poison.h
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] question: about exec/poison.h |
|
Date: |
Mon, 30 Nov 2015 10:28:08 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 30/11/2015 04:47, Peter Xu wrote:
>>
>> I met one problem when trying to add a new public function in dump.h
>> named "dump_state_get_global" and using it in hmp.c.
>
> Don't do that. :)
>
> hmp.c functions should in general use the QMP commands as the base. In
> your case, hmp_info_dump should call qmp_query_dump.
Yes. HMP commands need to be implemented on top of QMP commands, to
avoid a feature gap. Exception: HMP commands that make no sense for
QMP, like "print" or "cpu".