[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] question: about exec/poison.h
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] question: about exec/poison.h |
Date: |
Mon, 30 Nov 2015 18:45:22 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Nov 30, 2015 at 11:36:41AM +0100, Paolo Bonzini wrote:
>
>
> On 30/11/2015 10:47, Peter Xu wrote:
> > So from what I understand from your reply, I could include the
> > percentage value into "query-dump", right? :)
>
> If you have the written and total bytes in the QMP reply, you can use
> total*100/written to compute the percentage in the HMP return value.
>
> If total and written do not produce the percentage, you need to add
> another numerator and denominator pair to the QMP reply.
Then I will use written/total numbers in QMP reply.
>
> > Actually, I think it would be cooler if we could have them in both
> > QMP/HMP messages (maybe I would better prefer percentage comparing
> > to written/total bytes, since it is more directly human
> > readable).
>
> For HMP yes. QMP need not be human readable, it only needs to be a good
> API (which sometimes means being less human readable).
Ok. Thanks.
Peter
>
> Paolo