[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] qmp: add support for system_suspend
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] qmp: add support for system_suspend |
Date: |
Mon, 30 Nov 2015 11:10:39 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/27/2015 08:01 PM, Chen Hanxiao wrote:
> From: Chen Hanxiao <address@hidden>
>
> This patch add support for system_suspend qmp command.
>
> Signed-off-by: Chen Hanxiao <address@hidden>
> ---
> qapi-schema.json | 9 +++++++++
> qmp-commands.hx | 21 +++++++++++++++++++++
> qmp.c | 5 +++++
> 3 files changed, 35 insertions(+)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 8b1a423..78bbb29 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3971,3 +3971,12 @@
> ##
> { 'enum': 'ReplayMode',
> 'data': [ 'none', 'record', 'play' ] }
> +
> +##
> +# @system_suspend:
> +#
> +# Performs suspend operation of a guest.
> +#
> +# Since: 2.5
> +##
> +{ 'command': 'system_suspend' }
You've missed 2.5; this should be since 2.6. Also, new QMP commands
should be named with '-' rather than '_'; so this should be
'system-suspend'. (Yes, I know 'system_wakeup' already exists with the
older spelling).
How does this command differ from the existing ability to use
qemu-guest-agent to request the guest put itself into suspend state?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature