Re: [Qemu-devel] [PATCH 0/7] target-i386: MMReg struct cleanup

[Richard Henderson]

On 11/30/2015 10:21 AM, Eduardo Habkost wrote:
> This is an attempt to cleanup the MMXReg/XMMReg structs and make
> their names, fields and usage consistent.
>
> The last 2 patches use a bit of macro magic to generate the union
> definitions and ensure type safety when using the field helper
> macros, and I am sending them as RFCs.

It all looks ok, as far as it goes.

Though I wonder if it wouldn't be better to reorg everything to work akin to 
the aarch64 method -- process everything in 64-bit chunks, via TCG registers, 
rather than via pointers to structures.

That would much easier let mmx and sse (and avx2 and avx512) use the same set 
of helpers, with much less need for all this macro-ization in the first place.


r~