[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/12] dump-guest-memory: using static DumpSt
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/12] dump-guest-memory: using static DumpState, add DumpStatus |
Date: |
Tue, 1 Dec 2015 10:57:08 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Nov 30, 2015 at 02:00:28PM +0100, Paolo Bonzini wrote:
> > +/* init dump state with specific status */
> > +static void dump_state_prepare(DumpState *s, DumpStatus status)
> > +{
> > + bzero(s, sizeof(*s));
> > + s->status = status;
>
> Either use memcpy, or
>
> s = (DumpState) { .status = status };
>
> The latter is C99 and it's quite common in QEMU.
Thanks to let me know this. :) Will use it in v4.
>
> > +}
> > +
> > +static DumpState *dump_state_get_global(void)
>
> No need for dump_state_get_global, just use a static variable. Then you
> can use &dump_state in qmp_dump_guest_memory.
Ok.
>
> > +{
> > + static DumpState state;
>
> You can also initialize it together with the definition, using
>
> static DumpState state = { .status = DUMP_STATUS_NONE };
>
Yes. Thanks.
Peter
- [Qemu-devel] [PATCH v3 00/12] Add basic "detach" support for dump-guest-memory, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 01/12] dump-guest-memory: cleanup: removing dump_{error|cleanup}()., Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 02/12] dump-guest-memory: add "detach" flag for QMP/HMP interfaces., Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 03/12] dump-guest-memory: using static DumpState, add DumpStatus, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 04/12] dump-guest-memory: add dump_in_progress() helper function, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 05/12] dump-guest-memory: introduce dump_process() helper function., Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 06/12] dump-guest-memory: disable dump when in INMIGRATE state, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 07/12] dump-guest-memory: add "detach" support, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 08/12] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/11/30