Re: [Qemu-devel] [PATCH for-2.5 v4 4/4] tests: add vhost-user-test when target is x64 only

[Alex Bennée]

address@hidden writes:

> From: Marc-André Lureau <address@hidden>
>
> check-qtest-x86_64-y is overwritten by the last assignment. Move
> vhost-user-test addition after.
>
> Reported-by: Alex Bennée <address@hidden>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  tests/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 0ef00a1..cf1228b 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -198,13 +198,13 @@ check-qtest-i386-y += tests/pc-cpu-test$(EXESUF)
>  check-qtest-i386-y += tests/q35-test$(EXESUF)
>  gcov-files-i386-y += hw/pci-host/q35.c
>  check-qtest-i386-$(CONFIG_VHOST_NET_TEST_i386) += 
> tests/vhost-user-test$(EXESUF)
> -ifeq ($(CONFIG_VHOST_NET_TEST_i386),)
> -check-qtest-x86_64-$(CONFIG_VHOST_NET_TEST_x86_64) += 
> tests/vhost-user-test$(EXESUF)
> -endif
>  check-qtest-i386-y += tests/test-netfilter$(EXESUF)
>  check-qtest-x86_64-y = $(check-qtest-i386-y)
>  gcov-files-i386-y += i386-softmmu/hw/timer/mc146818rtc.c
>  gcov-files-x86_64-y = $(subst 
> i386-softmmu/,x86_64-softmmu/,$(gcov-files-i386-y))
> +ifeq ($(CONFIG_VHOST_NET_TEST_i386),)
> +check-qtest-x86_64-$(CONFIG_VHOST_NET_TEST_x86_64) += 
> tests/vhost-user-test$(EXESUF)
> +endif

So is this limitation due to the guest binary we need to test this?
Surely any KVM enabled build with vhost support should be able to run
the test?

>  check-qtest-mips-y = tests/endianness-test$(EXESUF)
>  check-qtest-mips64-y = tests/endianness-test$(EXESUF)
>  check-qtest-mips64el-y = tests/endianness-test$(EXESUF)


--
Alex Bennée