Re: [Qemu-devel] [PATCH v3 3/8] hw/arm/virt-acpi-build: Add power button device in ACPI DSDT table

[Shannon Zhao]

Hi Igor,

On 2015/12/1 21:05, Igor Mammedov wrote:
>>>>> +static void acpi_dsdt_add_power_button(Aml *scope)
>>>>> > >> > +{
>>>>> > >> > +    Aml *dev = aml_device("PWRB");
>>>>> > >> > +    aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C")));
>>>>> > >> > +    aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
>>>>> > >> > +    aml_append(dev, aml_name_decl("_UID", aml_int(0)));
>>>>> > >> > +    Aml *method = aml_method("_STA", 0);
>>>>> > >> > +    aml_append(method, aml_return(aml_int(0x0F)));
>>>>> > >> > +    aml_append(dev, method);
>>> > > since _STA always returns 0xF you can just drop it altogether,
>>> > > as _STA == 0xF is implied if it's not present.
>>> > > 
>> > 
>> > Yes, but I think adding this is harmless and make the return value 
>> > explicit.
> It's useless and consumes several bytes, it's better to drop it unless you 
> have to have it.
> 
Sure, will drop it. :)

BTW, could you have a look at other ACPI patches in this series? Thanks
in advance!

-- 
Shannon