[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] coverity: Model g_poll()
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] coverity: Model g_poll() |
|
Date: |
Tue, 01 Dec 2015 14:34:41 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 01/12/2015 14:03, Markus Armbruster wrote:
>> Coverity now reports two more CHECKED_RETURN:
>>
>> * qemu-char.c:1248: Should be fixed by Paolo's "qemu-char: retry
>> g_poll on EINTR".
>>
>> * migration/qemu-file-unix.c:75: if g_poll() fails, we retry sending
>> before the file descriptor is ready. Errors other than EINTR are
>> mostly theoretical, though.
>
> EINTR is harmless too here, you'll just get another EAGAIN. I'll mark
> it as Intentional / Fix Required in the coverity dashboard.
I posted a cleanup patch anyway. Migration maintainers can decide
whether they want it or not.