[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump"
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump" |
Date: |
Tue, 1 Dec 2015 06:43:26 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/30/2015 09:40 PM, Peter Xu wrote:
>>> +++ b/qmp-commands.hx
>>> @@ -881,7 +881,7 @@ EQMP
>>> {
>>> .name = "query-dump-guest-memory-capability",
>>> .args_type = "",
>>> - .mhandler.cmd_new = qmp_marshal_query_dump_guest_memory_capability,
>>> + .mhandler.cmd_new = qmp_marshal_query_dump_guest_memory_capability,
>>> },
>>
>> Unrelated hunk.
>
> Is it ok to have this line here? I just saw it and fixed it. Please
> let me know if I should move it out of this patch.
It's small enough that you could separate that hunk into its own patch
and cc qemu-trivial.
As it is, Marc-Andre has queued patches that get rid of qmp-commands.hx;
so if Markus and I can get through the backlog of qapi patches, this
problem may just disappear on its own.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump",
Eric Blake <=