Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

[Eric Blake]

On 12/01/2015 07:28 AM, Denis V. Lunev wrote:
>>>>   +void qmp_savevm(bool has_name, const char *name, Error **errp)
>>>> +{
>>>> +    do_savevm(has_name ? name : NULL, errp);
>>>> +}
>>>> +
>>> Please name do_savevm() qmp_savevm() and drop this wrapper.
>>>
>>> We're working on omitting has_FOO for pointer-valued FOO.
>> Agreed.
>>
> 
> is there a tree with this stuff in or something I could be based on?
> This series is simple enough to be written fast and be merged
> early when the hard freeze will be done.

I have started the work in my local tree, but have not posted it yet.
I'll try and remember to cc you when it's ready (right now, there are
more than 20 qapi patches from me and another 35 or so from Marc-Andre
that need reviewing before we'd even get to the point of my work on
dropping has_FOO for pointers).

> 
> Above stuff could have a way harder way due to the amount of
> changes to be performed.

Dropping has_FOO will be rather invasive; my plan is to add a per-struct
marker to the .json files on which structs are ready to use the leaner
layout, then do a series of patches that adjusts a couple structs at a
time and catches all fallout for those structs.  Then, if everything
converts nicely to the leaner form, I can remove the per-struct marker
in the end.  So it's not a problem to just keep the three-argument form
with has_name for now.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature