Re: [Qemu-devel] [PATCH 0/5] audio/coreaudio.c: Fix deprecation warnings

[Programmingkid]

On Nov 28, 2015, at 4:55 PM, Peter Maydell wrote:

> The coreaudio.c code has for some years now produced compilation
> warnings about our use of various APIs that were deprecated starting
> with OSX 10.6. This patchset updates our code to use their replacements.
> 
> I have been a bit conservative with the approach to moving away from
> AudioDeviceGetProperty/AudioDeviceSetProperty, because different sources
> on the web suggest either 10.6 or 10.5 was the point at which you could
> move to AudioObjectGetProperty/AudioObjectSetProperty, but I don't have
> a 10.5 system to test with. So I've left the old code in for when building
> on 10.5 (removing it would be a trivial matter of dropping a lot of ifdeffed
> code).
> 
> Incidentally, on the subject of OSX 10.5, I think we should finally
> drop support for it unless anybody would like to volunteer to actually
> test building on it. I'll send a separate email about that.
> 
> (This patch set is intended for 2.6, not 2.5.)
> 
> Peter Maydell (5):
>  audio/coreaudio.c: Factor out use of AudioHardwareGetProperty
>  audio/coreaudio.c: Use new-in-OSX-10.6 API for getting default voice
>  audio/coreaudio.c: Factor out uses of AudioDeviceGet/SetProperty
>  audio/coreaudio.c: Use new-in-OSX-10.6 APIs when available
>  audio/coreaudio.c: Avoid deprecated AudioDeviceAdd/RemoveIOProc APIs
> 
> audio/coreaudio.c | 314 +++++++++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 252 insertions(+), 62 deletions(-)
> 
> -- 
> 2.6.2

All the patches applied and compiled without problem on Mac OS 10.6.8. I played 
video and mp3 files in QEMU running a Windows XP guest. They all played 
perfectly. 

I really was against the idea of removing Mac OS 10.5 support when I first 
heard the idea. But I did think about it before saying anything. I personally 
started out building QEMU on Mac OS 10.3. But that was years ago. Technology 
has moved on. Everyone wants to run their emulator on the fastest hardware they 
have. This hardware is probably not going to include anything running Mac OS 
10.5. Removing Mac OS 10.5 support might be a good idea. I don't think we would 
inconvenience anyone. The only evidence I found of someone using Mac OS 10.5 to 
build QEMU was from 2012. 

We are only removing support for Mac OS 10.5 because of a warning message that 
appears during compilation. We could just disable warnings for that file. But 
the depreciated audio functions might
not be around in the future, so probably better to say goodbye to them now 
before they cause real problems.