Re: [Qemu-devel] [PATCH v4 01/11] dump-guest-memory: cleanup: removing dump_{error|cleanup}().

[Peter Xu]

On Wed, Dec 02, 2015 at 08:37:36AM +0800, Fam Zheng wrote:
> On Tue, 12/01 21:28, Peter Xu wrote:
> > It might be a little bit confusing to do dump_cleanup() in these two
> > functions and error prone. A better way is to do dump_cleanup()
> 
> I would say "It might be a little bit confusing and error prone to do
> dump_cleanup() in ..."

Yes. Changing it.

Thanks.
Peter

> 
> Other than that,
> 
> Reviewed-by: Fam Zheng <address@hidden>
> 
> > before dump finish, no matter whether dump has succeeded or not.
> > 
> > Signed-off-by: Peter Xu <address@hidden>