Re: [Qemu-devel] [PATCH v4 09/11] DumpState: adding total_size and written_size fields

[Fam Zheng]

On Wed, 12/02 16:49, Peter Xu wrote:
> On Wed, Dec 02, 2015 at 09:32:57AM +0800, Fam Zheng wrote:
> > > @@ -1301,6 +1303,7 @@ static void write_dump_pages(DumpState *s, Error 
> > > **errp)
> > >                  goto out;
> > >              }
> > >          }
> > > +        s->written_size += TARGET_PAGE_SIZE;
> > 
> > The same question applies here.
> 
> For kdump case, it is using "goto out" when error happens. So it
> seems to have no problem here?

write_cache can fail after you increment it here, no?

Fam