[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED |
Date: |
Wed, 2 Dec 2015 17:57:16 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 12/02 16:20, Peter Xu wrote:
> On Wed, Dec 02, 2015 at 09:11:31AM +0800, Fam Zheng wrote:
> > On Tue, 12/01 21:28, Peter Xu wrote:
> > > +
> > > +##
> > > +# @DUMP_COMPLETED
> > > +#
> > > +# Emitted when background dump has completed
> > > +#
> > > +# @error: #optional human-readable error string that provides
> > > +# hint on why dump failed.
> >
> > Please explicitly mention that successful dump emits DUMP_COMPLETED without
> > error, and failed dump emits DUMP_COMPLETED that has an error str.
>
> Ok. I can add more words to describe it. Maybe something like:
>
> # @error: #optional human-readable error string that provides
> # hint on why dump failed. Only presents on failure. The
> # user should not try to interpret the error string.
>
> How do you think about this one?
That looks ok.
- [Qemu-devel] [PATCH v4 04/11] dump-guest-memory: add dump_in_progress() helper function, (continued)
- [Qemu-devel] [PATCH v4 04/11] dump-guest-memory: add dump_in_progress() helper function, Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 05/11] dump-guest-memory: introduce dump_process() helper function., Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 06/11] dump-guest-memory: disable dump when in INMIGRATE state, Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 07/11] dump-guest-memory: add "detach" support, Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/12/01
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Fam Zheng, 2015/12/01
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Eric Blake, 2015/12/02
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/12/02
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Eric Blake, 2015/12/02
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/12/02
[Qemu-devel] [PATCH v4 09/11] DumpState: adding total_size and written_size fields, Peter Xu, 2015/12/01