qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH v2 07/21] block: Pass driver-specif


From: Alberto Garcia
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 07/21] block: Pass driver-specific options to .bdrv_refresh_filename()
Date: Wed, 02 Dec 2015 15:06:40 +0100
User-agent: Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu)

On Mon 23 Nov 2015 04:59:46 PM CET, Kevin Wolf <address@hidden> wrote:
> In order to decide whether a blkdebug: filename can be produced or a
> json: one is necessary, blkdebug checked whether bs->options had more
> options than just "config", "x-image" or "image" (the latter including
> nested options). That doesn't work well when generic block layer options
> are present.
>
> This patch passes an option QDict to the driver that contains only
> driver-specific options, i.e. the options for the general block layer as
> well as child nodes are already filtered out. Works much better this
> way.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>

Reviewed-by: Alberto Garcia <address@hidden>

Berto



reply via email to

[Prev in Thread] Current Thread [Next in Thread]