[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui: vnc: avoid floating point exception
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] ui: vnc: avoid floating point exception |
Date: |
Thu, 3 Dec 2015 12:32:09 +0000 |
On 3 December 2015 at 12:11, Gerd Hoffmann <address@hidden> wrote:
> On Do, 2015-12-03 at 17:07 +0530, P J P wrote:
>> Hello Gerd,
>>
>> A floating point exception issue in the VNC server PNG compression support
>> was
>> reported by Mr Lian Yihan, CC'd here. Given below is a proposed (tested)patch
>> to fix this issue.
>
>> - vs->client_pf.rmax = red_max;
>> + vs->client_pf.rmax = red_max ? red_max : 0xFF;
>
> Looks good.
>
> Reviewed-by: Gerd Hoffmann <address@hidden>
>
> Peter, can you pick this up directly for 2.5-rc3?
The patch doesn't apply to master. Can you produce a version
that does, please?
thanks
-- PMM