Re: [Qemu-devel] MinGW build

[Peter Maydell]

On 3 December 2015 at 11:58, Peter Maydell <address@hidden> wrote:
> On 29 November 2015 at 12:03, Juan Quintela <address@hidden> wrote:
>> Peter Maydell <address@hidden> wrote:
>>> Yes, I've reported it to them, and I agree we don't need to fix
>>> this for 2.5. (There are other warnings with this mingw compiler
>>> anyway.)
>>
>> For my compiler (F23 cross-compiler) and a fairly large configuration (*)
>> this is the only warning.
>
> The others I see are:
>
>   CC    qga/commands.o
> In file included from
> /home/petmay01/linaro/mingw64/lib/glib-2.0/include/glibconfig.h:9:0,
>                  from
> /home/petmay01/linaro/mingw64/include/glib-2.0/glib/gtypes.h:34,
>                  from
> /home/petmay01/linaro/mingw64/include/glib-2.0/glib/galloca.h:34,
>                  from 
> /home/petmay01/linaro/mingw64/include/glib-2.0/glib.h:32,
>                  from /home/petmay01/linaro/qemu-for-merges/qga/commands.c:13:
> /home/petmay01/linaro/qemu-for-merges/qga/commands.c: In function
> ‘qmp_guest_exec_status’:
> /home/petmay01/linaro/mingw64/include/glib-2.0/glib/gmacros.h:162:53:
> error: typedef ‘_GStaticAssertCompileTimeAssertion_0’ locally defined
> but not used [-Werror=unused-local-typedefs]
>  #define G_STATIC_ASSERT(expr) typedef char G_PASTE
> (_GStaticAssertCompileTimeAssertion_, __COUNTER__)[(expr) ? 1 : -1]
>                                                      ^
> /home/petmay01/linaro/mingw64/include/glib-2.0/glib/gmacros.h:159:47:
> note: in definition of macro ‘G_PASTE_ARGS’
>  #define G_PASTE_ARGS(identifier1,identifier2) identifier1 ## identifier2
>                                                ^
> /home/petmay01/linaro/mingw64/include/glib-2.0/glib/gmacros.h:162:44:
> note: in expansion of macro ‘G_PASTE’
>  #define G_STATIC_ASSERT(expr) typedef char G_PASTE
> (_GStaticAssertCompileTimeAssertion_, __COUNTER__)[(expr) ? 1 : -1]
>                                             ^
> /home/petmay01/linaro/mingw64/include/glib-2.0/glib/gatomic.h:79:5:
> note: in expansion of macro ‘G_STATIC_ASSERT’
>      G_STATIC_ASSERT (sizeof *(atomic) == sizeof (gint));                     
> \
>      ^
> /home/petmay01/linaro/qemu-for-merges/qga/commands.c:157:21: note: in
> expansion of macro ‘g_atomic_int_get’
>      bool finished = g_atomic_int_get(&gei->finished);
>                      ^

It looks like these were fixed in glib upstream:
https://git.gnome.org/browse/glib/commit/?id=0ea7abaed5
(I'm using glib 2.34.3-1, which doesn't have the fix.)

thanks
-- PMM