[Qemu-devel] Posible regressions around spapr-dr-connector property drc-connector[]

[Markus Armbruster]

1. Before commit 94649d4 "spapr: Don't use QOM [*] syntax for DR
   connectors", the indexes were small integers:

       (qemu) info qom-tree
       /machine (pseries-2.4-machine)
         /unattached (container)
           [...]
           /device[5] (spapr-pci-host-bridge)
             /address@hidden (qemu:memory-region)
             /address@hidden (qemu:memory-region)
             /address@hidden (qemu:memory-region)
             /address@hidden (qemu:memory-region)
             /pci.0 (PCI)
             /address@hidden (qemu:memory-region)
             /dr-connector[0] (spapr-dr-connector)
             /dr-connector[1] (spapr-dr-connector)
             /dr-connector[2] (spapr-dr-connector)
             [...]

   Since then, they're big ones:

             /dr-connector[1073741824] (spapr-dr-connector)
             /dr-connector[1073741825] (spapr-dr-connector)
             /dr-connector[1073741826] (spapr-dr-connector)

   The commit message doesn't quite spell out this change, and I'm
   therefore double-checkint it's intentional.  Is it?

2. Before commit 6c2f9a1 "qapi: Make output visitor return qnull()
   instead of NULL", qom-get returned {}:

   Since then, it returns null:

       QMP> { "execute": "qom-get", "arguments": { "path": 
"/machine/unattached/device[5]/dr-connector[1073741950]", "property": "fdt" } }
       {"return": null}

   Does anyone care?