qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors pr


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors properly
Date: Thu, 3 Dec 2015 09:45:56 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 12/03/2015 09:37 AM, Markus Armbruster wrote:
> Since prop_get_fdt() is only used with QmpOutputVisitor, errors
> shouldn't actually happen, so this is only a latent bug.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  hw/ppc/spapr_drc.c | 32 ++++++++++++++++++++++++++------
>  1 file changed, 26 insertions(+), 6 deletions(-)

I posted a similar patch, but using &error_abort rather than
propagating, here:
https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg05788.html

But I like yours better.

> 
> diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
> index f34bc04..4e7a1d3 100644
> --- a/hw/ppc/spapr_drc.c
> +++ b/hw/ppc/spapr_drc.c

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]