[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-co
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device |
Date: |
Thu, 3 Dec 2015 09:55:24 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/03/2015 09:37 AM, Markus Armbruster wrote:
> It should only be created via spapr_dr_connector_new(). Attempting to
> create it with -device crashes.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/ppc/spapr_drc.c | 4 ++++
> 1 file changed, 4 insertions(+)
For 2.5, this is an appropriate last-minute crash-avoider. The FIXME
reminds us to do better in 2.6.
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
> index dad157f..8be62c3 100644
> --- a/hw/ppc/spapr_drc.c
> +++ b/hw/ppc/spapr_drc.c
> @@ -599,6 +599,10 @@ static void spapr_dr_connector_class_init(ObjectClass
> *k, void *data)
> drck->attach = attach;
> drck->detach = detach;
> drck->release_pending = release_pending;
> + /*
> + * Reason: it crashes FIXME find and document the real reason
> + */
> + dk->cannot_instantiate_with_device_add_yet = true;
> }
>
> static const TypeInfo spapr_dr_connector_info = {
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}, (continued)
Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}, David Gibson, 2015/12/03
[Qemu-devel] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors properly, Markus Armbruster, 2015/12/03
[Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device, Markus Armbruster, 2015/12/03
Re: [Qemu-devel] [PATCH for-2.5 0/3] spapr_drc: Last minute bug fixes, Markus Armbruster, 2015/12/03