Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

[Jason Wang]

On 12/03/2015 03:24 PM, Dmitry Fleytman wrote:
> Acked-by: Dmitry Fleytman <address@hidden <mailto:address@hidden>>

Applied in my -net for 2.5.

Thanks

>
>> On 3 Dec 2015, at 07:08 AM, Miao Yan <address@hidden
>> <mailto:address@hidden>> wrote:
>>
>> Macro MAC_FMT and MAC_ARG are not defined, but used in
>> vmxnet3_net_init().
>> This will cause build error when debug level is raised in
>> vmxnet3_debug.h (enable all VMXNET3_DEBUG_xxx).
>>
>> Use VMXNET_MF and VXMNET_MA instead.
>>
>> Signed-off-by: Miao Yan <address@hidden
>> <mailto:address@hidden>>
>> ---
>> hw/net/vmxnet3.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
>> index 5e3a233..ea3d9b7 100644
>> --- a/hw/net/vmxnet3.c
>> +++ b/hw/net/vmxnet3.c
>> @@ -2044,7 +2044,7 @@ static void vmxnet3_net_init(VMXNET3State *s)
>>
>>     s->link_status_and_speed = VMXNET3_LINK_SPEED |
>> VMXNET3_LINK_STATUS_UP;
>>
>> -    VMW_CFPRN("Permanent MAC: " MAC_FMT, MAC_ARG(s->perm_mac.a));
>> +    VMW_CFPRN("Permanent MAC: " VMXNET_MF, VMXNET_MA(s->perm_mac.a));
>>
>>     s->nic = qemu_new_nic(&net_vmxnet3_info, &s->conf,
>>                           object_get_typename(OBJECT(s)),
>> -- 
>> 2.1.4
>>
>