[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice
From: |
Kevin O'Connor |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object |
Date: |
Fri, 4 Dec 2015 13:49:28 -0500 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Dec 04, 2015 at 12:55:07PM +0000, Peter Maydell wrote:
> On 4 December 2015 at 12:50, Markus Armbruster <address@hidden> wrote:
> > To finally answer your question: the proper owner of the property
> > connecting the backend is the frontend half of the split device. So, if
> > we have separate device models for controller and the block devices
> > connected to it, the block backend property belongs to the latter, not
> > the former. If we have separate device models for SD controller and
> > card, the block backend property belongs to the card, not the
> > controller.
>
> I thought this might be your answer, but this is problematic because
> we now have a device in the tree (the sdhci pci card) which has the
> property on the controller, and so that's now user-facing command
> line ABI which we can't change...
If by ABI, you mean the command line format:
-device sdhci-pci,drive=drive0 -drive id=drive0,if=sd,file=myimage
then I don't see why that should change. As Paolo points out, there
is only one card per controller. That's how real hardware does it as
well.
Cheers,
-Kevin
- Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object, Peter Maydell, 2015/12/03
- Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object, Markus Armbruster, 2015/12/04
- Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object, Paolo Bonzini, 2015/12/04
- Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object, Peter Crosthwaite, 2015/12/04
- Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object, Kevin O'Connor, 2015/12/04
- Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object, Peter Crosthwaite, 2015/12/06
- Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object, Kevin O'Connor, 2015/12/07
- Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object, Markus Armbruster, 2015/12/07
- Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object, Paolo Bonzini, 2015/12/07
- Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object, Markus Armbruster, 2015/12/07
- Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object, Peter Maydell, 2015/12/07