qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.6 0/2] Preparation for PCI devices convert


From: Cao jin
Subject: Re: [Qemu-devel] [PATCH for-2.6 0/2] Preparation for PCI devices convert to realize()
Date: Mon, 7 Dec 2015 10:42:21 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

Hi John

On 12/05/2015 01:55 AM, John Snow wrote:


On 12/04/2015 02:47 AM, Cao jin wrote:
Hi,
     As you know, there are many PCI devices still using .init() as its
     initialization function, I am planning to do the "convert to realize()"
     work, and PCI bridge devices are chosen first.
     The supporting functions should be modified first. msi_init() a supporting
     function for PCI devices.

     Maybe it should be put in 2.6, as title indicated

Cao jin (2):
   Add param Error** to msi_init()
   Modify callers of msi_init()

  hw/audio/intel-hda.c               |  7 ++++++-
  hw/ide/ich.c                       |  2 +-
  hw/net/vmxnet3.c                   |  3 ++-
  hw/pci-bridge/ioh3420.c            |  6 +++++-
  hw/pci-bridge/pci_bridge_dev.c     |  6 +++++-
  hw/pci-bridge/xio3130_downstream.c |  7 ++++++-
  hw/pci-bridge/xio3130_upstream.c   |  7 ++++++-
  hw/pci/msi.c                       | 17 +++++++++++++----
  hw/scsi/megasas.c                  |  2 +-
  hw/scsi/vmw_pvscsi.c               |  3 ++-
  hw/usb/hcd-xhci.c                  |  5 ++++-
  hw/vfio/pci.c                      |  3 ++-
  include/hw/pci/msi.h               |  4 ++--
  13 files changed, 55 insertions(+), 17 deletions(-)


You'll need to squash these patches as the first patch will break git
bisect.


Ok, will squash it. And I have another question: what`s the benefit of converting to realize? Because AFAICT, doing this make the error reporting machanism seems clean & clear, all device-init errors are passed above along the call chain. I mean, besides, are there any other benefits?

--js


.


--
Yours Sincerely,

Cao Jin





reply via email to

[Prev in Thread] Current Thread [Next in Thread]