[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] qemu-file: fix flaws of qemu_put_compressio
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] qemu-file: fix flaws of qemu_put_compression_data |
|
Date: |
Mon, 7 Dec 2015 15:09:06 +0800 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Dec 04, 2015 at 11:52:07AM +0800, Liang Li wrote:
> There are some flaws in qemu_put_compression_data, this patch tries
> to fix it. Now it can be used by other code.
This commit description is vague and doesn't explain what this patch
does or why it is necessary.
Please try to cover "what" and "why" instead of just saying that the
patch fixes flaws. If there are multiple points then maybe it should be
split into multiple patches.
Stefan
signature.asc
Description: PGP signature
Re: [Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data, Juan Quintela, 2015/12/04