[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid r
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid registers, rather than aborting |
Date: |
Mon, 7 Dec 2015 10:52:39 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/12/2015 06:20, Andrew Baumann wrote:
> Yeah, I considered doing that, but figured that those cases
> (incorrectly-sized register writes in 16-bit mode) are indicative of
> a pretty badly screwed-up guest, and was going for a minimal patch.
> It probably makes sense to change them for consistency, though.
I think those should be fixed by modifying lan9118_*_mem_ops and adding
.valid.{min,max}_access_size. Not for 2.5, however. (Probably these
patches should also be 2.6 + qemu-stable rather than 2.5).
Paolo
- [Qemu-devel] [PATCH 0/2] minor fixes to lan9118 emulation, Andrew Baumann, 2015/12/04
- [Qemu-devel] [PATCH 1/2] lan9118: fix emulation of MAC address loaded bit in E2P_CMD register, Andrew Baumann, 2015/12/04
- [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid registers, rather than aborting, Andrew Baumann, 2015/12/04
- Re: [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid registers, rather than aborting, Jason Wang, 2015/12/06
- Re: [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid registers, rather than aborting, Andrew Baumann, 2015/12/07
- Re: [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid registers, rather than aborting,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid registers, rather than aborting, Andrew Baumann, 2015/12/07
- Re: [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid registers, rather than aborting, Paolo Bonzini, 2015/12/09