[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] xen/MSI-X: latch MSI-X table writes
From: |
Jan Beulich |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/4] xen/MSI-X: latch MSI-X table writes |
Date: |
Mon, 07 Dec 2015 09:46:20 -0700 |
>>> On 07.12.15 at 13:41, <address@hidden> wrote:
> I know that in your opinion is superfluous, nonetheless could you please
> add 2-3 lines of in-code comment right here, to explain what you are
> doing with the check? Something like:
>
> /*
> * Update the entry addr and data to the latest values only when the
> * entry is masked or they are all masked, as required by the spec.
> * Addr and data changes while the MSI-X entry is unmasked will be
> * delayed until the next masking->unmasking.
> */
Btw, will it be okay to just resend this one patch as v3, or do I need
to resend the whole series (the rest of which didn't change)?
Jan