[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 00/11] Add basic "detach" support for dump-gu
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 00/11] Add basic "detach" support for dump-guest-memory |
Date: |
Mon, 7 Dec 2015 15:13:02 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/06/2015 10:56 PM, Peter Xu wrote:
> v5 changes:
> - patch 1
> - comment English fix [Fam]
> - patch 2
> - pass has_detach=true always in hmp_dump_guest_memory [Paolo]
> - patch 3
> - always use local_err and error_propagate() when need to check
> the result [Fam]
> - patch 8
> - add "DumpQueryResult" in DUMP_COMPLETED event [Eric]
> (since DumpQueryResult is introduced in patch 10, so doing it in
> patch 10 for convenience. Please let me know if I should not do
> this, e.g., if patch re-ordering is required)
All patches should build in isolation. It looks like you met that goal
(you introduce 'DUMP_COMPLETED' event in 8 without a 'result' member,
then modify it in 10), so that it at least builds. But it results in
churn, in that you have multiple different definitions of
'DUMP_COMPLETED' over the life of the series.
It's not a requirement to rework things since each step builds, but if I
were writing the series, I do find it conceptually easier to supply
patches in an order that minimizes churn (the first patch that
introduces a type uses its final form, rather than going through several
iterations of that type). So on that grounds, introducing
DumpQueryResult as a separate patch, before either DUMP_COMPLETED or
query-dump, might be easier to review, if there is a reason for a v6 spin.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v5 06/11] dump-guest-memory: disable dump when in INMIGRATE state, (continued)
- [Qemu-devel] [PATCH v5 07/11] dump-guest-memory: add "detach" support, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 09/11] DumpState: adding total_size and written_size fields, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 10/11] Dump: add qmp command "query-dump", Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 11/11] Dump: add hmp command "info dump", Peter Xu, 2015/12/07
- Re: [Qemu-devel] [PATCH v5 00/11] Add basic "detach" support for dump-guest-memory, Fam Zheng, 2015/12/07
- Re: [Qemu-devel] [PATCH v5 00/11] Add basic "detach" support for dump-guest-memory,
Eric Blake <=