Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)

[Marc-André Lureau]

Hi

On Thu, Dec 10, 2015 at 1:53 AM,  <address@hidden> wrote:
> From: Marc-André Lureau <address@hidden>
>
> "type" is not POSIX shell, but a bashism. (found thanks to shellcheck)
>

A subsidiary question is whether qemu really care about using POSIX
shell, or we can just depend on bashism. That would help with
simplifying some Makefile lines too.

> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index ba57b3f..90eff82 100755
> --- a/configure
> +++ b/configure
> @@ -158,7 +158,7 @@ symlink() {
>  # check whether a command is available to this shell (may be either an
>  # executable or a builtin)
>  has() {
> -    type "$1" >/dev/null 2>&1
> +    which "$1" >/dev/null 2>&1
>  }
>
>  # search for an executable in PATH
> --
> 2.5.0
>
>



-- 
Marc-André Lureau