[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010) |
|
Date: |
Wed, 9 Dec 2015 19:52:32 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/09/2015 05:57 PM, Marc-André Lureau wrote:
> Hi
>
> On Thu, Dec 10, 2015 at 1:53 AM, <address@hidden> wrote:
>> From: Marc-André Lureau <address@hidden>
>>
>> "type" is not POSIX shell, but a bashism. (found thanks to shellcheck)
>>
>
> A subsidiary question is whether qemu really care about using POSIX
> shell, or we can just depend on bashism. That would help with
> simplifying some Makefile lines too.
Debian uses dash, not bash, as /bin/sh. As both 'configure' and
'Makefile' depend on '/bin/sh', then yes, we care about POSIX compliance.
Only in scripts that explicitly require /bin/bash, such as much of the
scripts under tests/, can we get away with bashisms.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature