Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

[Samuel Thibault]

Thomas Huth, on Fri 11 Dec 2015 14:38:44 +0100, wrote:
> > +    switch (iph->ip_v) {
> > +    case IPVERSION:
> >      if (iph->ip_dst.s_addr == 0) {
> >          /* 0.0.0.0 can not be a destination address, something went wrong,
> >           * avoid making it worse */
> 
> That indentation looks now broken - shouldn't the if-statement now be
> indented with four more spaces now?

Please see the patch summary: I was asked to provided a non-reindented
patch and then a reindent patch.

> Also, I'd prefer if you could split this patch into two: One for
> renaming the "arp_requested" field, and one for adding the additional
> logic with the switch statement (since there are two different kind of
> changes).

TBH I'm starting to again lose motivation.

Samuel