qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code


From: Samuel Thibault
Subject: Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff
Date: Fri, 11 Dec 2015 14:47:06 +0100
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Thomas Huth, on Fri 11 Dec 2015 14:43:42 +0100, wrote:
> Anyway, it's IMHO a somewhat strange way to structure a patch ... maybe
> it would be nicer to do it in one go instead (after splitting off the
> arp_requested renaming)?

Please discuss about it with the people who asked for it.  I won't
revamp patches until what people prefer is settled.

Personally I prefer the two-patch approach, since the first nicely shows
what behavior change we have, and the second is a no-op patch, as can be
seen with diff -w

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]