qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] checkpatch: Detect newlines in error_report and


From: Jason J. Herne
Subject: Re: [Qemu-devel] [PATCH] checkpatch: Detect newlines in error_report and other error functions
Date: Fri, 11 Dec 2015 13:31:59 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 12/11/2015 09:52 AM, Jason J. Herne wrote:
We don't want newlines embedded in error messages. This seems to be a common
problem with new code so let's try to catch it with checkpatch.

This does not catch the newline when it is in a multiline statement. This is
quite a bit more difficult and can be handled as follow on work.

Signed-off-by: Jason J. Herne <address@hidden>
...

Ignore this one, I found some time to write up a better version that handles the most common multi-line cases. See v2. Sorry for the spam :)

--
-- Jason J. Herne (address@hidden)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]