qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 00/11] Avoid always-active qemu_log calls


From: Paolo Bonzini
Subject: [Qemu-devel] [PATCH 00/11] Avoid always-active qemu_log calls
Date: Sat, 12 Dec 2015 11:36:16 +0100

qemu_log calls should generally be wrapped by DEBUG_* preprocessor
symbols or (preferred) qemu_log_mask should be used instead.  This 
avoids that the upcoming integration of logging and tracing prints
some log messages to stderr unconditionally.

Similarly, most occurrences of qemu_log_enabled() should be changed
to qemu_log_mask().  One exception is when these always-active qemu_log
calls are coupled with printfs to stdout or stderr.  These should be
skipped if stderr is _already_ the logging destination, and the
series thus introduces a new predicate qemu_log_separate() to
replace qemu_log_enabled() in some cases.

This series removes all the instances that I could find of these
problems.

Paolo

Paolo Bonzini (11):
  qemu-log: introduce qemu_log_separate
  alpha: convert "naked" qemu_log to tracepoint
  cris: avoid "naked" qemu_log
  microblaze: avoid "naked" qemu_log
  s390x: avoid "naked" qemu_log
  ppc: cleanup logging
  tricore: avoid "naked" qemu_log
  xtensa: avoid "naked" qemu_log
  user: introduce "-d page"
  linux-user: avoid "naked" qemu_log
  linux-user: convert DEBUG_SIGNAL logging to tracepoints

 bsd-user/main.c               |   4 +-
 bsd-user/signal.c             |   2 -
 exec.c                        |   2 +-
 hw/alpha/pci.c                |   3 +-
 hw/char/etraxfs_ser.c         |   2 +-
 include/qemu/log.h            |   8 +++
 linux-user/elfload.c          |   8 +--
 linux-user/main.c             |  75 ++++++++++++---------------
 linux-user/signal.c           | 118 +++++++++++++++++++++---------------------
 qemu-log.c                    |   2 +
 target-cris/helper.h          |   1 -
 target-cris/op_helper.c       |   5 --
 target-cris/translate.c       |   8 +--
 target-cris/translate_v10.c   |   2 +-
 target-microblaze/helper.c    |   2 +-
 target-microblaze/mmu.c       |  20 +++----
 target-microblaze/op_helper.c |   8 +--
 target-microblaze/translate.c |   2 +-
 target-ppc/excp_helper.c      |   8 +--
 target-ppc/mmu-hash32.c       |  12 +----
 target-ppc/mmu-hash64.c       |   9 +---
 target-ppc/mmu_helper.c       |  15 +++---
 target-ppc/timebase_helper.c  |  10 ++--
 target-ppc/translate.c        |  62 +++++++++++-----------
 target-s390x/cc_helper.c      |   2 +-
 target-s390x/helper.c         |   2 +-
 target-s390x/misc_helper.c    |   2 +-
 target-s390x/mmu_helper.c     |   2 +-
 target-tricore/helper.c       |   4 +-
 target-xtensa/gdbstub.c       |   8 +--
 target-xtensa/helper.c        |   4 +-
 target-xtensa/op_helper.c     |  20 +++----
 target-xtensa/translate.c     |  28 +++++-----
 target-xtensa/xtensa-semi.c   |   2 +-
 trace-events                  |  14 +++++
 35 files changed, 237 insertions(+), 239 deletions(-)

-- 
2.5.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]