qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 0/4] fix debug macro pattern for vmxnet3


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH v3 0/4] fix debug macro pattern for vmxnet3
Date: Mon, 14 Dec 2015 13:49:04 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0


On 12/08/2015 02:29 PM, Dmitry Fleytman wrote:
>
> Reviewed-by: Dmitry Fleytman <address@hidden
> <mailto:address@hidden>>
>
>> On 8 Dec 2015, at 07:28 AM, Miao Yan <address@hidden
>> <mailto:address@hidden>> wrote:
>>
>> This patchset fixes debug macro pattern for vmxnet3. The old style uses
>> #ifdef...#else...#endif to define debug macros, as a result
>> the format string inside the macro will never be checked
>> (debug not turned on by default) and is likely to cause build
>> errors in the future when enabled.
>>
>> Changes in v3:
>> - fix a build error on 32 bit platforms
>>
>> Changes in v2:
>> - fix grammar errors in commit log
>>
>> Miao Yan (4):
>>  net/vmxnet3: fix a build error when enabling debug output
>>  net/vmxnet3: use %zu for size_t in printf
>>  net/vmxnet3: fix debug macro pattern for vmxnet3
>>  net/vmxnet3: remove redundant VMW_SHPRN(...) definition
>>
>> hw/net/vmware_utils.h |   5 +-
>> hw/net/vmxnet3.c      |   8 +--
>> hw/net/vmxnet_debug.h | 139
>> +++++++++++++++++++++++++++++++-------------------
>> 3 files changed, 91 insertions(+), 61 deletions(-)
>>
>> -- 
>> 1.9.1
>>
>

Queued for 2.6.

Thanks



reply via email to

[Prev in Thread] Current Thread [Next in Thread]