[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

[Peter Maydell]

Actually it turns out we really shouldn't be using the ${} syntax anyway, 
because if nettle is not present we end up printing
"nettle: no ()"
because $nettle is set to "no", not null or unset. So we should just write this 
out like:
if test "$nettle" = "yes"; then
    echo "nettle            $nettle ($nettle_version)"
else
    echo "nettle            $nettle"
fi

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1525682

Title:
  configure: fix POSIX compatibility issue

Status in QEMU:
  New

Bug description:
  When running configure script from 2.5.0-rc4 on OpenBSD-current
  (amd64), I get the following error:

    ./configure[4756]: ${nettle:+($nettle_version)}": bad substitution
    *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2747 
'/usr/ports/pobj/qemu-2.5.0rc4/.configure_done')
    *** Error 1 in /usr/ports/openbsd-wip/emulators/qemu 
(/usr/ports/infrastructure/mk/bsd.port.mk:2491 'configure')

  Indeed, construct "${nettle:+($nettle_version)}" does not conform to
  POSIX Shell Command Language. The attached patch fixes the issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1525682/+subscriptions